Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Use symfony for IPUtils #210

Merged
merged 1 commit into from
Aug 19, 2024
Merged

API Use symfony for IPUtils #210

merged 1 commit into from
Aug 19, 2024
+3 −2

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Aug 19, 2024
Closed
3 tasks
GuySartorelli
GuySartorelli requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the dependency here - we should always add the dep if we're directly using its API.

@emteknetnz emteknetnz force-pushed the pulls/2/use-symfony branch from d451c64 to 8c23041 Compare August 19, 2024 22:07
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit c19e81c into silverstripe:2 Aug 19, 2024
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/use-symfony branch August 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli